Skip to content

[Notifier] Add Firebase bridge #33968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2020
Merged

[Notifier] Add Firebase bridge #33968

merged 1 commit into from
Feb 10, 2020

Conversation

Jeroeny
Copy link
Contributor

@Jeroeny Jeroeny commented Oct 12, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets See #33687
License MIT

This would add Firebase integration for the Notifier component. With Firebase you can send push notifications to the users of you Android and iOS app and website (formerly known as Google Cloud messaging).

I'm not sure if it's possible to have this merged, like the other bridges. Or if I should create a stand-alone repository? That'd be fine too.

Also it's now using the ChatMessage as implementation of Symfony\Component\Notifier\Message\MessageInterface, but I feel like this component could use a PushMessage or something similar. Although I'm not sure if it would contain more than subject that the ChatMessage does.

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Oct 13, 2019
@nicolas-grekas nicolas-grekas modified the milestones: 5.0, next Nov 6, 2019
@fabpot
Copy link
Member

fabpot commented Feb 10, 2020

Thank you @Jeroeny.

@fabpot fabpot closed this in 7e4abf5 Feb 10, 2020
@fabpot fabpot merged commit 2776d2f into symfony:master Feb 10, 2020
@acasademont
Copy link
Contributor

After seeing fabpot's talk today talking about the Firebase notifier coming in 5.1 I looked at the repo and noticed that this Firebase notifier is based on the old Http API, that allows quite a lot less options than the new one, specifically, the new one allows you to send in 1 message different options for different platforms (iOS, Android, Web) instead of having to send separate messages for each of the platforms.

Not sure @Jeroeny if this is something that should be changed before the 5.1 release?

https://firebase.google.com/docs/cloud-messaging/migrate-v1

@fabpot
Copy link
Member

fabpot commented Apr 18, 2020

@acasademont I would recommend to open a new issue.

@fabpot fabpot mentioned this pull request May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants