[Filesystem] Improve exists() behaviour to be able to differentiate files/dirs #34037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Oct 20, 2019
OskarStark
reviewed
Oct 21, 2019
stof
reviewed
Oct 21, 2019
OskarStark
reviewed
Oct 21, 2019
darielopper
approved these changes
Oct 21, 2019
|
What about not having this implemented as options to be passed to the |
|
I'm closing because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of Filesystem::exists allowed to check whether a file is present on the filesystem, without any kind of distinction on the file type, so it is blind about the fact that it can be a file, directory, symlink, socket, ...
The new (optional) second argument allows to specify whether we want to check against a specific file type. I used the standard Unix/POSIX file types definition (see https://en.wikipedia.org/wiki/Unix_file_types), and implemented regular/directory. Class constants were added to list/use the available file types.
The change is BC and didn't alter the default/previous behaviour. I already pushed a usage example in the associated documentation.