Allow PHP ^7.2.5 #34443
Allow PHP ^7.2.5 #34443
Conversation
nicolas-grekas
requested review from
dunglas,
lyrixx,
sroze and
xabbuh
as code owners
|
Looks good to me (appveyor failure is unrelated - existed before) |
|
Out of curiosity: Do you know why |
|
I think it's the version Debian ships |
|
Why was the min PHP-version lowered to |
|
.0 versions are always buggy and we don't want to test with them and workaround these early bugs. |
|
mhm, seems to not being accepted? |
|
Note: https://www.php.net/ChangeLog-7.php#PHP_7_2 Maybe a good idea to note somewhere that, although Symfony supports 7.2.5, it is advised to always update to latest patch? Also, I would guess the core team already has ideas/has thought about this, but 7.1 security support is being dropped at the end of the month. Same for 7.2 only receiving security patches as of 30 nov. Haven't seen documentation specifically relating to this? (Symfony 3.4 LTS supports 7.0 and up?) |
|
Could be, but SUSE Linux (up to 15) only has php 7.2.5. This is a major show stopper. |
|
Distributions backport security fixes, that's why ppl pay for them. It's not our job to safeguard ppl from themselves :) |
|
tests are failing for the Cache PdoAdapter and the Lock PdoStore. Not sure whether this is related to the new PHP version or whether they were already broken on Windows. |
|
Thank you @nicolas-grekas. |
This PR was merged into the 5.0 branch. Discussion ---------- Allow PHP ^7.2.5 | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #34442 | License | MIT | Doc PR | - Let's what the CI says. Will need tagging all contracts as v2.0.1 after merge. Commits ------- 6194c2a Allow PHP ^7.2.5
|
Will this trickle down to the repo https://github.com/symfony/contracts/blob/master/composer.json ? |
|
@Defcon0 yes, see PR description :) Should be applied to symfony/*skeleton also |
This PR was merged into the 5.0 branch. Discussion ---------- Update to ^7.2.5 Follow up from symfony/symfony#34443 Commits ------- d8b3eb4 Update to ^7.2.5
This PR was merged into the 5.0 branch. Discussion ---------- Update to ^7.2.5 Follow up from symfony/symfony#34443 Commits ------- 69e213b Update to ^7.2.5
|
@nicolas-grekas Could you please tag the contracts bundle to 2.0.1? We need the fix quite urgently ;-) Thanks! |
|
Any news on the 2.0.1 contracts tag? |
The core team is probably busy with SymfonyCon right now. Please have a little patience. You can require |
This PR was merged into the 5.0 branch. Discussion ---------- Set PHP Version requirement to 7.2.5 Based on the last pull request for 5.0 the minimum PHP Version is 7.2.5 symfony/symfony#34443 That's also the required version in composer.json https://github.com/symfony/symfony/blob/5.0/composer.json#L19 Commits ------- 3d50d78 Set PHP Version requirement to 7.2.5
Let's what the CI says.
Will need tagging all contracts as v2.0.1 after merge.