Hello @jgallant

Thanks for your first contribution.

Unfortunately, I would like to not add yet another deprecation. We have a solid upgrade path in Symfony, but deprecation are always boring to fix.

TransitionBlockerList was introduced to be able to attach a nice message from a guard when rejecting a transition to display it to the end user. During this work, I kept the setBlocked() method to keep the BC and also because it is possible to choose to not display a message to the end user.

So Instead of removing the setBlocked() method, I would instead change the default message to put something much more explicit and easier to debug.

Could you update the PR?

i see 2 issues with setBlocked;

• the message is implicit, and not obvious to discover its root cause (a better message may help though)
• the blocker list is implicitly cleared, which is a side effect

For users addBlocker($msg, $code) would be much appreciated, as keep doing $event->addTransitionBlocker(new TransitionBlocker($msg, $code)) becomes boring over time :}

or with implicit clear: setBlocker($msg, $code)

or with implicit clear: setBlocker($msg, $code)

I like this proposal

I just looked at the code and setBlocked(bool $blocked) accepts a bool. So we can not change change it to setBlocked($msg, $code) without a deprecation notice then BC Break (in SF 6.0).

As I said, I would like to avoid to add another deprecation.

So the best option is to change the default message...

For users addBlocker($msg, $code) would be much appreciated, as keep doing $event->addTransitionBlocker(new TransitionBlocker($msg, $code)) becomes boring over time :}

@fabpot What is your position concerning this kind of API? Should we stick to something really explicit, or could we add some shortcuts to make thing easier by hiding the reality. I know you already forbid $definition->addTransition('name', 'from', 'to') to keep $defintion->addTransition(new Transition('name', 'from', 'to')) so I think we should not add theses shortcut, But I understand it could be boring...

->setBlocked(bool, $msg = 'Some default') LGTM

Closing in favor of #34573
Thanks for raising the point.