[ErrorHandler] Enabled the dark theme for exception pages #34924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 🚢 💯 |
fabpot
approved these changes
Dec 11, 2019
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Dec 11, 2019
…ges (javiereguiluz) This PR was merged into the 5.1-dev branch. Discussion ---------- [ErrorHandler] Enabled the dark theme for exception pages | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This makes the exception pages compatible with the dark theme. By default, they use the same setting as the Profiler. If no setting is defined, it auto-selects the theme based on the operating system theme. Some comparison screenshots:   Commits ------- 24f32f8 [ErrorHandler] Enabled the dark theme for exception pages
stof
reviewed
Dec 11, 2019
| @@ -66,7 +66,7 @@ | |||
| --metric-unit-color: #999; | |||
| --metric-label-background: #777; | |||
| --metric-label-color: #e0e0e0; | |||
| --trace-selected-background: #71663a; | |||
| --trace-selected-background: #71663acc; | |||
There was a problem hiding this comment.
The #RRGGBBAA notation for colors is not supported by Edge. I suggest using the rgba() notation instead.
| --metric-unit-color: #999; | ||
| --metric-label-background: #777; | ||
| --metric-label-color: #e0e0e0; | ||
| --trace-selected-background: #71663acc; |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the exception pages compatible with the dark theme. By default, they use the same setting as the Profiler. If no setting is defined, it auto-selects the theme based on the operating system theme.
Some comparison screenshots: