[Uid] use one class per type of UUID #36066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
uuid-classes
branch
2 times, most recently
from
029531a to
5f6a725
Compare
jakzal
reviewed
Mar 13, 2020
nicolas-grekas
force-pushed
the
uuid-classes
branch
2 times, most recently
from
96561be to
8441fb0
Compare
jakzal
reviewed
Mar 13, 2020
nicolas-grekas
force-pushed
the
uuid-classes
branch
from
8441fb0 to
c5bf578
Compare
|
#36064 has been merged now. |
fabpot
approved these changes
Mar 14, 2020
nicolas-grekas
force-pushed
the
uuid-classes
branch
from
c5bf578 to
a9bd234
Compare
|
thanks, rebased |
javiereguiluz
approved these changes
Mar 14, 2020
nicolas-grekas
force-pushed
the
uuid-classes
branch
from
a9bd234 to
3dd3b7b
Compare
lyrixx
approved these changes
Mar 14, 2020
nicolas-grekas
force-pushed
the
uuid-classes
branch
from
3dd3b7b to
62f6ac4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(embeds #36064 for now)
Would it make sense to have one class per type of UUID?
This aligns the type system and UUID types, so that one could type hint e.g.
UuidV4 $uuid.This PR does so.
UuidV1/2/3/4 andNullUuidall extend the baseUuidclass, which provides common methods and the factories needed to create each king of UUID.This means we don't need the
getType()nor theisNull()methods since they can be replaced by instanceof checks.As expected,
getTime()andgetMac()then now exist only on theUuidV1class - no need for any version check nor anyLogicExceptionanymore.Each type is guaranteed to contain a UUID that matches its class' type. The base
Uuidclass is used for the "no type" type.