-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Validator] Add missing translations #36165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Validator] Add missing translations #36165
Conversation
@@ -374,6 +374,14 @@ | |||
<source>The number of elements in this collection should be a multiple of {{ compared_value }}.</source> | |||
<target>Liczba elementów w tym zbiorze powinna być wielokrotnością {{ compared_value }}.</target> | |||
</trans-unit> | |||
<trans-unit id="97"> | |||
<source>This value should satisfy at least one of the following constraints:</source> | |||
<target>Ta wartość powinna spełniać co najmniej jedną z następujących reguł:</target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pizzaminded Since you've helped me before, maybe you could have a look at this translation? I had doubts whether to use ograniczenie
instead of reguła
(for translating constraint
), but I think that the second one is more natural and commonly used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, reguła
sounds better. Ograniczenie
is more about limiting something (e.g count of choices etc.) than "fitting" to requirements.
@@ -374,6 +374,14 @@ | |||
<source>The number of elements in this collection should be a multiple of {{ compared_value }}.</source> | |||
<target>El número de elementos en esta colección debería ser múltiplo de {{ compared_value }}.</target> | |||
</trans-unit> | |||
<trans-unit id="97"> | |||
<source>This value should satisfy at least one of the following constraints:</source> | |||
<target>Este valor debería satisfacer al menos una de las siguientes restricciones:</target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javiereguiluz Once again, I put my Spanish to the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 The proposed translation is perfect! Thanks.
@@ -19,10 +19,10 @@ | |||
*/ | |||
class AtLeastOneOf extends Composite | |||
{ | |||
public const AT_LEAST_ONE_ERROR = 'f27e6d6c-261a-4056-b391-6673a623531c'; | |||
public const AT_LEAST_ONE_OF_ERROR = 'f27e6d6c-261a-4056-b391-6673a623531c'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also noticed that the error name is not consistent with the classname.
0bd18c5
to
0c06856
Compare
Thank you @przemyslaw-bogusz. |
…s (mtarld) This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #36192). Discussion ---------- [Validator] Add french "at least" constraint translations | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT Completion of PR #36165 by adding french translation for "at least" constraint. Commits ------- f885822 Add french "at least" constraint translations
I forgot about it in the original PR (#35744) - sorry for the extra work.