Skip to content

[Validator] Add missing translations #36165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

przemyslaw-bogusz
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
License MIT

I forgot about it in the original PR (#35744) - sorry for the extra work.

@@ -374,6 +374,14 @@
<source>The number of elements in this collection should be a multiple of {{ compared_value }}.</source>
<target>Liczba elementów w tym zbiorze powinna być wielokrotnością {{ compared_value }}.</target>
</trans-unit>
<trans-unit id="97">
<source>This value should satisfy at least one of the following constraints:</source>
<target>Ta wartość powinna spełniać co najmniej jedną z następujących reguł:</target>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pizzaminded Since you've helped me before, maybe you could have a look at this translation? I had doubts whether to use ograniczenie instead of reguła (for translating constraint), but I think that the second one is more natural and commonly used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, reguła sounds better. Ograniczenie is more about limiting something (e.g count of choices etc.) than "fitting" to requirements.

@@ -374,6 +374,14 @@
<source>The number of elements in this collection should be a multiple of {{ compared_value }}.</source>
<target>El número de elementos en esta colección debería ser múltiplo de {{ compared_value }}.</target>
</trans-unit>
<trans-unit id="97">
<source>This value should satisfy at least one of the following constraints:</source>
<target>Este valor debería satisfacer al menos una de las siguientes restricciones:</target>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javiereguiluz Once again, I put my Spanish to the test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The proposed translation is perfect! Thanks.

@@ -19,10 +19,10 @@
*/
class AtLeastOneOf extends Composite
{
public const AT_LEAST_ONE_ERROR = 'f27e6d6c-261a-4056-b391-6673a623531c';
public const AT_LEAST_ONE_OF_ERROR = 'f27e6d6c-261a-4056-b391-6673a623531c';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also noticed that the error name is not consistent with the classname.

@fabpot fabpot force-pushed the at_least_translations branch from 0bd18c5 to 0c06856 Compare March 23, 2020 08:23
@fabpot
Copy link
Member

fabpot commented Mar 23, 2020

Thank you @przemyslaw-bogusz.

@fabpot fabpot merged commit 1b90621 into symfony:master Mar 23, 2020
@przemyslaw-bogusz przemyslaw-bogusz deleted the at_least_translations branch March 23, 2020 19:26
@nicolas-grekas nicolas-grekas added this to the next milestone Mar 24, 2020
xabbuh added a commit that referenced this pull request Mar 25, 2020
…s (mtarld)

This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #36192).

Discussion
----------

[Validator] Add french "at least" constraint translations

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| License       | MIT

Completion of PR #36165 by adding french translation for "at least" constraint.

Commits
-------

f885822 Add french "at least" constraint translations
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants