Fix constant accessor #36379
Merged
Fix constant accessor #36379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
approved these changes
Apr 7, 2020
nicolas-grekas
approved these changes
Apr 7, 2020
stof
approved these changes
Apr 7, 2020
|
should be considered minor when merging rather than bug, as this is a bug in unreleased code only. |
GrahamCampbell
approved these changes
Apr 7, 2020
|
Testing failures seem unrelated... |
fabpot
approved these changes
Apr 8, 2020
|
Thank you @driesvints. |
|
@stof Merging it as a bug or minor does not change a lot as bug fixes are not listed in the CHANGELOG for new minor versions (only PRS tagged with feature). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because HTTP_RESPONSE_CACHE_CONTROL_DIRECTIVES is private, using static will fail for any classes extending the Response class. HTTP_RESPONSE_CACHE_CONTROL_DIRECTIVES is already properly using self a bit lower so we should do the same thing here.
Introduced in #35748