Add symfony/polyfill-php80 as requirement #36384
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see #36057 (comment) :) i think your i agree shipping unanalyzable code by default is not the best of practices though, so i wouldnt mind core adding it. |
|
Thanks for the link! Makes sense to me 👍 |
The code is perfectly analyzable as is: the meaning of the interface is defined in https://wiki.php.net/rfc/stringable |
|
Add the following to your <issueHandlers>
<UndefinedDocblockClass>
<errorLevel type="suppress">
<referencedClass name="Stringable"/>
</errorLevel>
</UndefinedDocblockClass>
</issueHandlers> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony uses the
Stringableinterface in theTokenInterfaceclass in Symfony 4.4, however it does not requiresymfony/polyfill-php80before Symfony 5.1 (see composer.json@4.4 and composer.json@master), therefore the class is undefined in PHP 7 + Symfony 4.Thanks to @leofeyer for debugging it (see contao/contao#1647).