[Notifier] Throw an exception when the Slack DSN is not valid #36516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koc
reviewed
Apr 21, 2020
| @@ -59,7 +60,10 @@ public static function fromString(string $dsn): self | |||
| $path = $parsedDsn['path'] ?? null; | |||
| parse_str($parsedDsn['query'] ?? '', $query); | |||
|
|
|||
| return new self($parsedDsn['scheme'], $parsedDsn['host'], $user, $password, $port, $query, $path); | |||
| $dsnObject = new self($parsedDsn['scheme'], $parsedDsn['host'], $user, $password, $port, $query, $path); | |||
| $dsnObject->dsn = $dsn; | |||
There was a problem hiding this comment.
Seems that this property can be non-initialized in case when Dsn object constructed through standard public constructor. This can lead to errors during getOriginalDsn call
There was a problem hiding this comment.
Indeed, can you submit a PR to fix that?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved errors in case of a DSN issue.