[DI] skip preloading dependencies of non-preloaded services #36535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
di-no-preload
branch
3 times, most recently
from
f7f9d1b to
13e7af3
Compare
stof
reviewed
Apr 23, 2020
| } | ||
| } | ||
| if ($noPreload && \count($extractingDispatcher->listeners) === $noPreload) { | ||
| $container->getDefinition($id)->addTag($this->noPreloadTagName); |
There was a problem hiding this comment.
What if a class is both a subscriber and tagged with additional kernel.listener tags ?
There was a problem hiding this comment.
Then we don't really care IMHO: it should be exceptional, thus not worth any extra complexity. And the outcome is minor anyway.
Tobion
reviewed
Apr 23, 2020
nicolas-grekas
force-pushed
the
di-no-preload
branch
from
13e7af3 to
add8670
Compare
Tobion
approved these changes
Apr 23, 2020
javiereguiluz
approved these changes
Apr 24, 2020
|
Thank you @nicolas-grekas. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @stof on Slack: this improves preloading by propagating the
container.no_preloadtag to services that are referenced only by not-preloaded services.The benefit is double:
As a corollary, listeners of console events are tagged with
container.no_preloadautomatically now.