[FrameworkBundle] Add option --as-tree to translation:update command #38393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
requested changes
Oct 4, 2020
| @@ -84,6 +84,7 @@ protected function configure() | |||
| new InputOption('domain', null, InputOption::VALUE_OPTIONAL, 'Specify the domain to update'), | |||
| new InputOption('xliff-version', null, InputOption::VALUE_OPTIONAL, 'Override the default xliff version', '1.2'), | |||
| new InputOption('sort', null, InputOption::VALUE_OPTIONAL, 'Return list of messages sorted alphabetically', 'asc'), | |||
| new InputOption('as-tree', null, InputOption::VALUE_NONE, 'Dump the messages as a tree-like structure'), | |||
There was a problem hiding this comment.
I would allow an argument which would be the "inline" option: --as-tree=3.
| @@ -13,6 +13,7 @@ CHANGELOG | |||
| * added `framework.http_client.retry_failing` configuration tree | |||
| * added `assertCheckboxChecked()` and `assertCheckboxNotChecked()` in `WebTestCase` | |||
| * added `assertFormValue()` and `assertNoFormValue()` in `WebTestCase` | |||
| * Added `--as-tree=3` option to `translation:update` command to dump messages as a tree-like structure. The given value defines the level where to switch to inline YAML | |||
| @@ -84,6 +84,7 @@ protected function configure() | |||
| new InputOption('domain', null, InputOption::VALUE_OPTIONAL, 'Specify the domain to update'), | |||
| new InputOption('xliff-version', null, InputOption::VALUE_OPTIONAL, 'Override the default xliff version', '1.2'), | |||
| new InputOption('sort', null, InputOption::VALUE_OPTIONAL, 'Return list of messages sorted alphabetically', 'asc'), | |||
| new InputOption('as-tree', null, InputOption::VALUE_OPTIONAL, 'Dump the messages as a tree-like structure: The given value defines the level where to switch to inline YAML'), | |||
There was a problem hiding this comment.
why not set the default value here?
There was a problem hiding this comment.
I wasn't sure about that at first, but decided to remove the default value because I can just call ...'as_tree' => $input->getOption('as-tree')... when setting the writers options which will result in 'as_tree' => null and with this make sure that the YamlFileDumper wouldn't call the ArrayConverter::expandToTree($data); method every time.
jschaedl
commented
Oct 5, 2020
jschaedl
commented
Oct 5, 2020
src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationUpdateCommandTest.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Oct 6, 2020
|
Thank you @jschaedl. |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Sep 20, 2023
…ull` command (syffer) This PR was merged into the 6.4 branch. Discussion ---------- [Translation] Add `--as-tree` option to `translation:pull` command | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes/no | New feature? | yes | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | todo This PR adds an option `--as-tree` to the command `translation:pull`, like the PR #38393 did it for the command `translation:extract`. This option would ease the use of the command `translation:pull` when the yaml translations are stored as a tree. Without it, the yaml translations are inlined after a `translation:pull`, regardless of whether it was stored as inline or as a tree. To bypass this, you would either have to - re-indent the yaml file yourself after a `translation:pull` - replace one service (e.g. `translation.dumper.yaml`) to forcefully add the option `as_tree` for the yaml file dumper Commits ------- 2f328ad [Translation] Add `--as-tree` option to `translation:pull` command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: