[Notifier ] Add Discord notifier #38522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorhu
force-pushed
the
discord-logger-handler
branch
from
359206d to
48b2321
Compare
|
Could you please rebase and squash the PR? |
|
@nicolas-grekas i've done the rebase and now fabbot says "code looks good" (and the conflict came back). |
|
To fix the conflict, you need to 1. fetch the upstream symfony/symfony repo 2. rebase on the 5.x branch of this repo. Please also squash so that the PR contains only one commit (or two if there are two authors). |
connorhu
force-pushed
the
discord-logger-handler
branch
from
2d8ddbe to
b1c317e
Compare
fabpot
approved these changes
Oct 12, 2020
fabpot
force-pushed
the
discord-logger-handler
branch
from
b1c317e to
b9b20d7
Compare
|
Thank you @connorhu. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It finish the PR #36475