[Mailer] Fix mailjet image embedding #38529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filename is not enough to embed the image through cid, ContentID field has to be set with the cid identifier used in the HTMLPart
fabpot
approved these changes
Oct 12, 2020
|
Thank you @Sandldan. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filename is not enough to embed the image through cid, ContentID field
has to be set with the cid identifier used in the HTMLPart
Hello!
While switching from
MandrilltoMailjetI noticed that embedding images was not working properly, theContent-IDmime is not set properly without setting theContentIDkey. With this change things will work as described in the symfony documentationMailjet reference