[Messenger] Add options to FailedMessagesShowCommand
#39330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
fguimier
changed the title
jderusse
reviewed
Dec 5, 2020
src/Symfony/Component/Messenger/Command/FailedMessagesShowCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/FailedMessagesShowCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/FailedMessagesShowCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/FailedMessagesShowCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/FailedMessagesShowCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/FailedMessagesShowCommand.php
Outdated
Show resolved
Hide resolved
fguimier
added a commit
to fguimier/symfony-docs
that referenced
this pull request
Dec 10, 2020
Update exemples for the messenger:failed:show command Add documentation regarding this PR symfony/symfony#39330
fguimier
added a commit
to fguimier/symfony-docs
that referenced
this pull request
Dec 10, 2020
Update exemples for the messenger:failed:show command Add documentation regarding this PR symfony/symfony#39330
fguimier
force-pushed
the
messenger-enhance-failed-show-cmd
branch
from
70c9347 to
6d16145
Compare
OskarStark
changed the title
FailedMessagesShowCommand
|
HI, it looks like your commiter email address is not associated with your Github Account:
|
jderusse
reviewed
Aug 4, 2021
src/Symfony/Component/Messenger/Command/FailedMessagesShowCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/FailedMessagesShowCommand.php
Outdated
Show resolved
Hide resolved
fguimier
force-pushed
the
messenger-enhance-failed-show-cmd
branch
from
6d16145 to
feba4b0
Compare
fguimier
force-pushed
the
messenger-enhance-failed-show-cmd
branch
from
feba4b0 to
c6cdb8f
Compare
derrabus
reviewed
Aug 27, 2021
Co-authored-by: Alexander M. Turek <me@derrabus.de>
fabpot
requested changes
Sep 21, 2021
| @@ -117,7 +117,7 @@ public function testBasicRunWithServiceLocator() | |||
| Error Things are bad! | |||
| Error Code 123 | |||
| Error Class Exception | |||
| Transport async | |||
| Transport async | |||
There was a problem hiding this comment.
The extra spaces should be removed
| @@ -198,7 +198,7 @@ public function testMultipleRedeliveryFailsWithServiceLocator() | |||
| Error Things are bad! | |||
| Error Code 123 | |||
| Error Class Exception | |||
| Transport async | |||
| Transport async | |||
There was a problem hiding this comment.
The extra spaces should be removed
carsonbot
changed the title
FailedMessagesShowCommandFailedMessagesShowCommand
carsonbot
changed the title
FailedMessagesShowCommandFailedMessagesShowCommand
|
Closing in favor of #47008, where I've made some minor changes to finish it. |
fabpot
added a commit
that referenced
this pull request
Jul 21, 2022
… (Florian Guimier, fabpot) This PR was merged into the 6.2 branch. Discussion ---------- [Messenger] Add options to `FailedMessagesShowCommand` | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #39330 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#14689 See #39330 Commits ------- e99d2ca Finish work 7f774b4 Add group and class-filter options to FailedMessagesShowCommand
javiereguiluz
pushed a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Aug 3, 2022
Update exemples for the messenger:failed:show command Add documentation regarding this PR symfony/symfony#39330
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal to this PR is to improve the FailedMessagesShowCommand usability by adding two options:
statsoption allows to display the number of messages by the class name and have a summary of all the failed messages.class-filteroption is a filter to only display the messages matching with the given class name.