-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Notifier] Use abstract test cases in 5.x #39749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I did not merge your changes from #39736 into 5.x because I didn't know how to resolve merge conflicts. Could you please update this PR to include the relevant changes that should be borrowed from 5.2? |
Sure 👍 |
c4138b4
to
3a94745
Compare
Looks ok now, don't know why two bridges have:
but not the other 🤔 |
Didn't we want to move those abstract test classes out of the Tests folder anyway on 5.x? |
Let's do it a little bit later because IIRC some open PRs for new bridges use it like this, and I want to get them merged before, otherwise it's a never ending story for them to get in 😑 |
3a94745
to
c233636
Compare
Those failures look like composer hickups to me: Composer could not fetch from git so it fell back to fetching the ZIP. I've rebased the PR to verify my hypothesis. |
Thank you Oskar. |
Thanks for the feedback ✌🏻 |
Same as #39736, but for
5.x
cc @derrabus