[FrameworkBundle] Make the TestBrowserToken interchangeable with other tokens #40368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seldaek
changed the title
chalasr
reviewed
Mar 5, 2021
chalasr
approved these changes
Mar 12, 2021
nicolas-grekas
force-pushed
the
add_token_getfirewall
branch
from
fdb5608 to
a4958ae
Compare
nicolas-grekas
approved these changes
Mar 16, 2021
|
Thank you @Seldaek. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 23, 2021
…s serialized (kbond) This PR was merged into the 5.2 branch. Discussion ---------- [FrameworkBundle] ensure TestBrowserToken::$firewallName is serialized | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a Fixes a bug introduced in #40368. When `TestBrowserToken` in unserialized, `$firewallName` is `null` so trying to access it via `getFirewallName` throws a `TypeError`. Commits ------- 8ba12ec [FrameworkBundle] ensure TestBrowserToken::$firewallName is serialized
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason most tokens implement getFirewallName (and the deprecated getProviderKey), but not all. This adds it to TestBrowserToken because it caused issues in my tests when upgrading to Symfony 5's
Client::loginUser().I am also happy to add this to AnonymousToken but I am more worried about BC impacts there, so I left it alone for now. All other token classes implement it, so I am not sure why this isn't in TokenInterface to begin with.