[HttpKernel] fix docblock #40611
[HttpKernel] fix docblock #40611
Conversation
xabbuh
commented
Mar 28, 2021
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 5.2 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
xabbuh
force-pushed
the
pr-40535
branch
2 times, most recently
from
5220f51 to
da181fc
Compare
|
This fixes tests where the code is patched to have real return type declarations. |
|
I think you are referring to this PR #40535 But I dont see how your fix solves the build. Could you please elaborate? |
| @@ -219,7 +219,7 @@ public function getEnv() | |||
| /** | |||
| * Returns true if the debug is enabled. | |||
| * | |||
| * @return bool true if debug is enabled, false otherwise | |||
| * @return bool|string true if debug is enabled, false otherwise or a string if no kernel was set | |||
There was a problem hiding this comment.
Is this better?
| * @return bool|string true if debug is enabled, false otherwise or a string if no kernel was set | |
| * @return bool|'n/a' true if debug is enabled, false otherwise or a string if no kernel was set |
There was a problem hiding this comment.
n/a is not a valid type I think
There was a problem hiding this comment.
n/ais not a valid type I think
'n/a' is a literal type. PHPStan and Psalm support literal types, but I'm not aware that we've ever used them in the Symfony codebase.
|
@Nyholm In the pipeline we have a job that patches our code to add real return type declarations. Which means here that when |
|
Oh. That is cool. I didn't know that. |
|
Thank you |
