Skip to content

[Config] Backport type declarations #41630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Jun 8, 2021

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

This PR backports type declarations from #41575 where it's safe to do so.

Signed-off-by: Alexander M. Turek <me@derrabus.de>
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally skip tests in such PRs because that provides nothing but a waste of my time when merging up. If you're willing to do the merge up, I'm fine :P

@derrabus
Copy link
Member Author

derrabus commented Jun 9, 2021

All the tests I've touched here still exist on 6.0, mostly unmodified. I'll happily do the merge. 🙂

@derrabus derrabus merged commit 510be7a into symfony:4.4 Jun 9, 2021
@derrabus derrabus deleted the types/config-backports branch November 21, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants