Skip to content

[Validator] Improve CssColorValidator regex to match colors with spac… #43368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Validator] Improve CssColorValidator regex to match colors with spac… #43368

wants to merge 1 commit into from

Conversation

flohw
Copy link
Contributor

@flohw flohw commented Oct 8, 2021

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT

Hi,

I just see a tweet about this new validator and spotted an edge case with colors like rgb( 34 , 35 , 12 ).
I know that this could be a rare case but still a case that can occur and should be valid.

I hope everything is correctly done to be able to merge this PR :-)

Thanks

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@flohw
Copy link
Contributor Author

flohw commented Oct 8, 2021

As @welcoMattic created a PR with more fixes in #43369 I will close this PR.

@flohw flohw closed this Oct 8, 2021
@flohw flohw deleted the improve-css-color-validator branch October 8, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants