Skip to content

[Serializer] Give more hints when an attribute is not correctly used #44790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2022
Merged

[Serializer] Give more hints when an attribute is not correctly used #44790

merged 1 commit into from
Jan 1, 2022

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Dec 24, 2021 •
edited
Loading

Q A
Branch? 6.1
Bug fix? no
New feature? kind of
Deprecations? no
Tickets
License MIT
Doc PR

before :
image

after

image

@lyrixx lyrixx requested a review from dunglas as a code owner December 24, 2021 13:24
@carsonbot carsonbot added this to the 6.1 milestone Dec 24, 2021
dunglas
dunglas approved these changes Dec 25, 2021
View reviewed changes
@lyrixx lyrixx force-pushed the serializer-better-exception branch from efe10c0 to 299be00 Compare December 28, 2021 16:02
@lyrixx
Copy link
Member Author

lyrixx commented Dec 28, 2021

Thanks for the review, I addressed your comments

@lyrixx lyrixx force-pushed the serializer-better-exception branch from 299be00 to 3616c85 Compare December 28, 2021 16:02
@nicolas-grekas
Copy link
Member

(please rebase to get rid of bad commits)

@lyrixx lyrixx force-pushed the serializer-better-exception branch from 3616c85 to e7488cb Compare December 29, 2021 11:20
@lyrixx
Copy link
Member Author

lyrixx commented Dec 29, 2021

@nicolas-grekas rebase done 👍🏼

@lyrixx lyrixx force-pushed the serializer-better-exception branch from e7488cb to 78bb078 Compare December 30, 2021 15:56
@fabpot
Copy link
Member

fabpot commented Jan 1, 2022

Thank you @lyrixx.

@fabpot fabpot merged commit cac5c09 into symfony:6.1 Jan 1, 2022
@fabpot fabpot mentioned this pull request Jan 1, 2022
Closed
@lyrixx lyrixx deleted the serializer-better-exception branch January 1, 2022 18:05
@fabpot fabpot mentioned this pull request Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas dunglas approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr Awaiting requested review from chalasr

@wouterj wouterj Awaiting requested review from wouterj

Assignees
No one assigned
Labels
Serializer Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
5 participants
@lyrixx @nicolas-grekas @fabpot @dunglas @carsonbot