[Yaml] Improve the deprecation warnings for octal numbers to suggest migrating #45085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for now, I provide the full replacement in the deprecation message. this might have a negative effect on the deduplication of deprecations. An alternative could be to mention only the |
stof
force-pushed
the
improve_yaml_deprecation
branch
from
8db4f1b to
6eca1a4
Compare
|
Hey! I think @alexandre-daubois has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
nicolas-grekas
force-pushed
the
improve_yaml_deprecation
branch
from
6eca1a4 to
4153af6
Compare
|
Thank you @stof. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing deprecation messages made some people think that octal numbers are totally unsupported in newer Symfony versions (see thephpleague/flysystem-bundle#81). This updates the deprecation message to provide the alternative when using an octal number is intended, to migrate to the Yaml 1.2 way of representing them.