[Notifier] Fix extensibility of Notification class
#46172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without using static it kills the extensibility of the `Notification` class as the `exception` and `exceptionAsString` properties are private and other methods such as `EmailMessage::fromNotification` use that to customize the message to send to channels.
derrabus
requested changes
Apr 26, 2022
| public static function fromThrowable(\Throwable $exception, array $channels = []): self | ||
| { | ||
| $parts = explode('\\', \get_class($exception)); | ||
|
|
||
| $notification = new self(sprintf('%s: %s', array_pop($parts), $exception->getMessage()), $channels); | ||
| $notification = new static(sprintf('%s: %s', array_pop($parts), $exception->getMessage()), $channels); |
There was a problem hiding this comment.
This change assumes that the child class has the same constructor signature as its parent which is not necessarily the case.
There was a problem hiding this comment.
Indeed, I missed that. Should we then just add a method exception? Like this:
/**
* @return $this
*/
public function exception(\Throwable $exception): self
{
$parts = explode('\\', \get_class($exception));
$this->subject = sprintf('%s: %s', array_pop($parts), $exception->getMessage());
if (class_exists(FlattenException::class)) {
$this->exception = $exception instanceof FlattenException ? $exception : FlattenException::createFromThrowable($exception);
}
$this->exceptionAsString = $this->computeExceptionAsString($exception);
return $this;
}There was a problem hiding this comment.
That sounds like a good idea. But we would need to target 6.2 with that.
There was a problem hiding this comment.
@andersonamuller Your suggestion seems good to me. Can you close this PR and open another one on 6.2 with the new exception() method?
carsonbot
changed the title
OskarStark
changed the title
Notification class
|
Closing in favor of #47038 |
fabpot
added a commit
that referenced
this pull request
Jul 23, 2022
This PR was merged into the 6.2 branch. Discussion ---------- [Notifier] Add Notification::exception() | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #46172 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | - Commits ------- 2db50f6 [Notifier] Add Notification::exception()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without using static it kills the extensibility of the
Notificationclass as theexceptionandexceptionAsStringproperties are private and other methods such asEmailMessage::fromNotificationuse that to customize the message to send to channels.