Skip to content

SMTP Transport to provide the (final) Message-ID if available #46326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2022
Merged

SMTP Transport to provide the (final) Message-ID if available #46326

merged 1 commit into from
Jul 20, 2022

Conversation

drzraf
Copy link

@drzraf drzraf commented May 11, 2022

bug #46323 [Mailer] SMTP transport does not provide the (final) Message-ID

Q A
Branch? 6.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #46323
License MIT
Doc PR symfony/symfony-docs#

Questions / Answers:

  • Q: Why storing 250 inside $mtaResult instead of using the already available $message->getDebug()?
  • A: Because the later may be huge (especially in case of attachment) and running a regexp over it would be less than safe. Instead $mtaResult only contains one line
  • Q: Why a new public method?
  • A: Because child SMTP Transport may make other assumptions about the return 250 Ok value and provide a custom logic / regexp.
  • Q: Why regexp?
  • A: Because there is no official standard for this line (other than the 250 Ok prefix)

Additionally (see https://symfony.com/releases):

@carsonbot carsonbot added this to the 6.1 milestone May 11, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@drzraf drzraf changed the title SMTP Transport to provide the (final) Message-ID if available [Mailer] SMTP Transport to provide the (final) Message-ID if available May 11, 2022
@carsonbot
Copy link

Hey!

I think @dmaicher has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

stof
stof requested changes May 12, 2022
View reviewed changes
@carsonbot carsonbot changed the title [Mailer] SMTP Transport to provide the (final) Message-ID if available SMTP Transport to provide the (final) Message-ID if available May 12, 2022
@fabpot fabpot modified the milestones: 6.1, 6.2 May 13, 2022
@drzraf
Copy link
Author

drzraf commented May 24, 2022 •
edited
Loading

ping @stof

(Review addressed)

@fabpot fabpot force-pushed the mailer-smtp-message-id branch from 60d0085 to 441c9b0 Compare July 20, 2022 17:35
@fabpot
Copy link
Member

fabpot commented Jul 20, 2022

Thank you @drzraf.

@fabpot fabpot merged commit 703596e into symfony:6.2 Jul 20, 2022
@xabbuh xabbuh mentioned this pull request Jul 29, 2022
Merged
@fabpot fabpot mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof requested changes

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.

[Mailer][Amazon] SMTP transport does not provide the (final) Message-ID
4 participants
@drzraf @carsonbot @fabpot @stof