Skip to content

[Dotenv] Run test in a separate process to have clean global state #47014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

rmikalkenas
Copy link
Contributor

Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

A fix to comment: #46502 (comment)
cc @chalasr

@chalasr
Copy link
Member

chalasr commented Jul 21, 2022

Thanks for looking at it!
Sadly this patch does not seem to fix the issue, see https://github.com/symfony/symfony/runs/7449393160?check_suite_focus=true#step:8:3691

@rmikalkenas
Copy link
Contributor Author

@chalasr unfortunately I'm not able to reproduce such behavior...

Test is failing on low-deps test case. Locally I run:

  • composer update --no-progress --ansi --prefer-lowest --prefer-stable
  • ./phpunit src/Symfony/Component/Dotenv ends with all greens

Could you help here? Maybe I'm doing something wrong

@stof
Copy link
Member

stof commented Jul 21, 2022

@rmikalkenas installing the lowest deps of the fullstack repo or the lowest deps of the component does not produce the same result.

@chalasr
Copy link
Member

chalasr commented Jul 21, 2022

Here is what is needed to reproduce the low-deps check locally assuming you are at the root directory of the symfony/symfony project:

cd src/Symfony/Component/Dotenv/
composer update --prefer-lowest --prefer-stable
../../../../phpunit

@rmikalkenas
Copy link
Contributor Author

@stof @chalasr thanks for the guidance, everything should be fine now. The rest failing tests have nothing to do with my changes

Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@fabpot
Copy link
Member

fabpot commented Jul 22, 2022

Thank you @rmikalkenas.

@fabpot fabpot merged commit 8be4d28 into symfony:6.2 Jul 22, 2022
@rmikalkenas rmikalkenas deleted the dotenv-test branch July 24, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants