[VarExporter] Improve partial-initialization API for ghost objects #48312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
lazy-partial
branch
from
0deed0e to
c5f79f6
Compare
stof
reviewed
Nov 24, 2022
nicolas-grekas
force-pushed
the
lazy-partial
branch
from
c5f79f6 to
c4926f0
Compare
stof
reviewed
Nov 24, 2022
nicolas-grekas
force-pushed
the
lazy-partial
branch
from
c4926f0 to
3a84d59
Compare
alcaeus
reviewed
Nov 24, 2022
nicolas-grekas
force-pushed
the
lazy-partial
branch
from
3a84d59 to
cd5bf0c
Compare
alcaeus
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
I've tested this against a small proof of concept I've been working on, and the object initialisation works as expected. Thanks @nicolas-grekas!
|
Thank you @nicolas-grekas. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed with @alcaeus at SymfonyCon, this improves support for partial-initialization of lazy ghost objects.
isLazyObjectInitialized(bool $partial = false): boolallows checking if an object is partially-initialized."\0"key can be used to initialize all/many properties at once.Targeting 6.2 because this would be a BC break in 6.3, also because this improves a new unreleased feature.