Make sure AuthenticationUtils::getLastUsername() returns a string
#48480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.0". Cheers! Carsonbot |
gjuric
requested review from
lyrixx,
yceruto,
dunglas,
OskarStark,
jderusse and
xabbuh
as code owners
OskarStark
changed the title
AuthenticationUtils::getLastUsername() returns a string
|
Thanks for the PR. |
|
Thank you, the issue was with the session value, not the attribute one, but the comments had me take another look at out codebase and I found the issue on our end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling AuthenticationUtils::getLastUsername() there is a return type hint that this method return a string, but
$request->getSession()->get(SecurityRequestAttributes::LAST_USERNAME, '')can also return null which throws a TypeError.This PR makes sure that the method return an empty string in such cases.