[HttpKernel] Fix using entities with the #[Cache()] attribute
#48509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Dec 6, 2022
nicolas-grekas
approved these changes
Dec 6, 2022
|
Thank you @HypeMC. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#[Cache()]attribute is suppose to be a replacement for the SensioFrameworkExtraBundle@Cacheannotation, but unlike the annotation, it doesn't work when entities are used in expressions. The reason for it is that theCacheAttributeListeneris triggered by akernel.controllerevent, while theEntityValueResolveris called afterwards:symfony/src/Symfony/Component/HttpKernel/HttpKernel.php
Lines 150 to 159 in 97f0ce8
This PR attempts to solve this problem by changing the event of the
CacheAttributeListenertokernel.controller_arguments. Even though this has a BC break the listener was introduced in 6.2 so it might still be early enough to make this change? In any case, I don't have a better idea how to fix this, so I'm open to suggestions.