Remove unused private methods #49517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
commented
Feb 23, 2023
| @@ -854,25 +854,6 @@ public function testCreateViewFlatlabelTranslationParametersClosureReceivesValue | |||
| $this->assertFlatViewWithlabelTranslationParameters($view); | |||
| } | |||
|
|
|||
| private function assertScalarListWithChoiceValues(ChoiceListInterface $list) | |||
There was a problem hiding this comment.
Was not removed when legacy tests were removed
31eb498#diff-18cef2a172697b433048f25490e0ccf5bec0b85c48b16040fb9fa3cd6bcfb4c9
alamirault
requested review from
nicolas-grekas
and removed request for
xabbuh and
yceruto
nicolas-grekas
force-pushed
the
feature/remove-unused-private-methods
branch
from
04525d3 to
53322dc
Compare
|
Thank you @alamirault. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 20, 2023
…w route to a collection (bram123) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [Routing] Fix routing collection defaults when adding a new route to a collection | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | ~ In our current Symfony project we use PHP routing files, and use routing collections that are setup before adding routes. Before upgrading to Symfony 6.3 this meant we could add an attribute to the collection, add X routes and they would all have this routing attribute (be it stateless / methods / defaults). After upgrading to S6.3 this no longer works. PR #49517 removed the createRoute method from the CollectionConfigurator, because it was thought to be unused, but this method was used when adding a new Route to a RouteCollection. Without the method, the createRoute method of the LocalizedRouteTrait was used. This means that when setting up a route collection before adding routes, the new routes no longer get the collection settings. Added a new unittest to prevent this from happening again. For now only added to the PhpFileLoaderTest, I don't know if this is also possible for XML/YML routing config to also add a test in those LoaderTests. Commits ------- bfdd16e [Routing] Fix routing collection defaults when adding a new route to a collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I searched all unused private methods in codebase and found these