[VarDumper] show uninitialized properties #50076
Conversation
|
Hey! Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.3 for features". Cheers! Carsonbot |
| $stubClass = $stub->value::class; | ||
| $stub->attr['uninitialized'] = []; | ||
| foreach ($uninitializedProps as $key => $value) { | ||
| $rp = new \ReflectionProperty($stubClass, $key); |
There was a problem hiding this comment.
Can you add a local cache for this?
| $stub->attr['uninitialized'] = []; | ||
| foreach ($uninitializedProps as $key => $value) { | ||
| $rp = new \ReflectionProperty($stubClass, $key); | ||
| $stub->attr['uninitialized'][] = [$key => $rp->getType()->getName()]; |
There was a problem hiding this comment.
this is broken for any union or intersection types. Not all ReflectionType are ReflectionNamedType.
| $stub->attr['uninitialized'] = []; | ||
| foreach ($uninitializedProps as $key => $value) { | ||
| $rp = new \ReflectionProperty($stubClass, $key); | ||
| $stub->attr['uninitialized'][] = [$key => $rp->getType()->getName()]; |
There was a problem hiding this comment.
why using a list of single-item arrays with an unknown key for this $stub->attr['uninitialized'] ? why not using $stub->attr['uninitialized'][$key] = $type here ?
| @@ -367,6 +367,14 @@ private function dumpItem(DumperInterface $dumper, Cursor $cursor, array &$refs, | |||
| $cut += \count($children); | |||
| } | |||
| $cursor->skipChildren = false; | |||
| // Add uninitialized properties | |||
| foreach ($item->attr["uninitialized"] as $uninitializedProperty) { | |||
There was a problem hiding this comment.
shouldn't this be done inside dumpChildren instead ? Otherwise, things will be weird when the cursor is meant to dump without children.
| @@ -128,6 +128,15 @@ protected function doClone(mixed $var): array | |||
| $stub->value = $v; | |||
| $stub->handle = $h; | |||
| $a = $this->castObject($stub, 0 < $i); | |||
| if ($stub->value !== '') { | |||
There was a problem hiding this comment.
Does this work for nested objects or should we implement that logic in castObject ?
And I'm wondering whether this should be implemented in Caster::castObject by adding those properties as a special UninitializedStub, so that this is done before any custom caster runs. This way, if a caster decides to cut a property, this would also cut it if it is uninitialized.
There was a problem hiding this comment.
I agree with this. I would add this to AbstractCloner::castObject, where there is already $this->classInfo that we can use to store those UninitializedStub.
There was a problem hiding this comment.
Ok I'll try implementing this solution. Thanks
guillaumeVDP
force-pushed
the
vardumper-show-uninitialized-properties
branch
from
7d978a0 to
a4684c3
Compare
|
I went with another approach in #51130 |
…kas) This PR was merged into the 6.4 branch. Discussion ---------- [VarDumper] Dump uninitialized properties | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #50054 | License | MIT | Doc PR | - Replaces #50076 Given this: ```php class Foo { private int|float $foo; public $baz; } $f = new Foo; unset($f->baz); dump($f); ``` This displays:  Commits ------- 54468db [VarDumper] Dump uninitialized properties
First commit for the feature. Please review this pull request and help me doing this in a good way 🙏
I am not sure if it's good to store uninitialized properties to the attr of the stub. Any better ideas ?
Missing: