[Config] Improve casting config nodes to array #51273
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
config-cast-to-array
branch
from
7b1952c to
e6694e6
Compare
|
@nicolas-grekas the scheduler test is already fixed with #51271 / #51274 and not related to your change! |
maxbeckers
reviewed
Aug 7, 2023
| @@ -77,7 +77,7 @@ public function ifTrue(\Closure $closure = null): static | |||
| public function ifString(): static | |||
| { | |||
| $this->ifPart = \is_string(...); | |||
| $this->allowedTypes = self::TYPE_STRING; | |||
| $this->allowedTypes = self::TYPE_STRING; // XXX why is this used by ConfigBuilderGenerator instead of the prototype? | |||
There was a problem hiding this comment.
By default it's type TYPE_ANY what results in mixed. For me it seems that this is a workaround to interpret this as a string after the check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interestingly, this makes tests fail in Config, see note in the patch.
Help wanted to understand what's going on and how to fix this.