Skip to content

[Notifier] Fix Smsmode HttpClient mandatory headers #51629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2023
Merged

[Notifier] Fix Smsmode HttpClient mandatory headers #51629

merged 1 commit into from
Sep 19, 2023

Conversation

inwebo
Copy link
Contributor

@inwebo inwebo commented Sep 11, 2023 •
edited
Loading

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets no
License MIT
Doc PR symfony/symfony-docs#...

As mentioned in the documentation https://dev.smsmode.com/sms/v1/home in section Content-Type & URL Encoding.

HTTP request and response bodies are JSON objects, which is why Accept and Content-Type headers are mandatory and are implicitly added when the request is executed with the TEST button. If the Accept header is missing, a Not Acceptable (406) HTTP status code is returned. (Accept: application/json) The Content-Type header is only needed with POST and PATCH methods. If it is missing, an Unsupported Media Type (415)

@inwebo inwebo requested a review from OskarStark as a code owner September 11, 2023 17:12
@carsonbot carsonbot added this to the 6.3 milestone Sep 11, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@derrabus
Copy link
Member

Thank you. Please add a test.

@derrabus derrabus added the Bug label Sep 11, 2023
@inwebo inwebo force-pushed the bugfix/SmsmodeTransport branch from c2f3631 to 1ed73fe Compare September 12, 2023 07:02
@inwebo
Copy link
Contributor Author

inwebo commented Sep 12, 2023

Hello,

I need help there, i don't get it why my simple PR is failing with Redis extension relay tests.

Regards

stof
stof requested changes Sep 12, 2023
View reviewed changes
@nicolas-grekas
Copy link
Member

i don't get it why my simple PR is failing with Redis extension relay tests.

It's unrelated, you can ignore these failures and focus on your changes.

@OskarStark OskarStark requested a review from stof September 13, 2023 09:32
@nicolas-grekas
Copy link
Member

Thank you @inwebo.

@nicolas-grekas nicolas-grekas merged commit a99b697 into symfony:6.3 Sep 19, 2023
@fabpot fabpot mentioned this pull request Sep 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

@stof stof Awaiting requested review from stof

Assignees
No one assigned
Labels
Bug Notifier Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
5 participants
@inwebo @carsonbot @derrabus @nicolas-grekas @stof