[Mime] Update mime types #52063
Merged
[Mime] Update mime types #52063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(test failures unrelated) |
OskarStark
approved these changes
Oct 14, 2023
smnandre
force-pushed
the
update-mime-types
branch
from
54eabd3 to
72bf76c
Compare
stof
reviewed
Oct 16, 2023
| @@ -14,7 +14,7 @@ | |||
| } | |||
|
|
|||
| // load new map | |||
| $data = json_decode(file_get_contents('https://cdn.jsdelivr.net/gh/jshttp/mime-db@v1.49.0/db.json'), true); | |||
| $data = json_decode(file_get_contents('https://cdn.jsdelivr.net/gh/jshttp/mime-db@v1.52.0/db.json'), true); | |||
There was a problem hiding this comment.
is there a way to make it use the latest version each time the script is run (as done for the freedesktop data below where we use the master branch) ?
There was a problem hiding this comment.
https://cdn.jsdelivr.net/gh/jshttp/mime-db/db.json?
| @@ -3145,7 +3209,6 @@ public function guessMimeType(string $path): ?string | |||
| 'snd' => ['audio/basic'], | |||
| 'snf' => ['application/x-font-snf'], | |||
| 'so' => ['application/x-sharedlib'], | |||
| 'so.[0-9]*' => ['application/x-sharedlib'], | |||
There was a problem hiding this comment.
Can you check why this was removed?
There was a problem hiding this comment.
The update script was updated to only put actual extensions in that list and not patterns (as our API does not deal with patterns). My guess is that the file was not properly regenerated when we did that change last time (otherwise it would have been removed at that time)
nicolas-grekas
added
the
❄️ Feature Freeze
nicolas-grekas
force-pushed
the
update-mime-types
branch
from
72bf76c to
d321cd8
Compare
|
Thank you @smnandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent update done in august (#51191) used an outdated version of the jshttp/mime-db database (See 1.49.0 .. 1.52.0)
The original reason I started this PR was to add the
application/yamltypeI fixed update_mime_types.php too, because the script failed to update the date in the
MAPdocblock.