[FrameworkBundle] Add conflict with WebProfilerBundle < 6.4
#52218
Conversation
HeahDude
commented
Oct 21, 2023
HeahDude
commented
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | #52210 |
| License | MIT |
|
Works for me, but can you think of any other way that wouldn't involve a conflict? |
|
The only other way I can think of would be to disallow FWB 6.4 by adding the conflict in WPB 5.4. |
|
If the problem happen only with 2 datacollectors, would it be possible to add a specific conflict ? FMB 6.4 has a conflict with worflow < 6.4, but allow console 5.4.. so i guess there won't be a problem with the new worflow profiler What if we add a conflict on console < 6.4 on FMB ? |
|
Thank you @HeahDude. |
|
@smnandre That wouldn’t have been enough to fix the issue at hand as the missing template is both located in and rendered by WPB. See the failing build which does run with Console v6.4-dev |
|
I "fixed" it in another way..... by declaring the collector separately --> Changes: 6.4...smnandre:symfony:fix/console-profiler But..... is it only because this one was merged ? (even if i restored the conflict as it was before ?) 😨 |
|
Send the PR! :) |
…tered (smnandre) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Fix CommandDataCollector is always registered | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #52210 | License | MIT Another attempt at fixing #52210, allowing to revert #52218 and leave the conflict constraints untouched CommandDataCollector was always registered, and not always removed from the container when not needed/invalid. Commits ------- 6e2c2ec [FrameworkBundle] Fix CommandDataCollector is always registered
