Added 'text/x-php' mimetype #53844
Added 'text/x-php' mimetype #53844
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1 for features / 5.4, 6.4, or 7.0 for bug fixes". Cheers! Carsonbot |
|
See #51141 (comment) |
I've experienced a small bug: calling Symfony\Component\HttpFoundation\File\File::guessExtension() on a .php file returns
null. I found that the reason is that Symfony\Component\Mime\MimeTypes::guessMimeType() is returning 'text/x-php' (on my system anyway), and when MimeTypes::getExtensions() is called on that mimetype it returns null because MimeTypes::MAP doesn't have an entry for 'text/x-php'.I have added the missing entry in what I believe is the right place, both in MimeTypes::MAP and MimeTypes::REVERSE_MAP