[FrameworkBundle] Display aliases in debug:container command
#54459
Conversation
94noni
force-pushed
the
framework-debug-container-alias
branch
3 times, most recently
from
fa98e0f to
48be857
Compare
94noni
force-pushed
the
framework-debug-container-alias
branch
from
48be857 to
f3e7977
Compare
| 'id' => (string) $value, | ||
| 'alias' => $node->getValue()->getClass(), | ||
| ]; | ||
| } else { |
|
Arf, I'm sorry but looking at the implementation, this is a false promise. This doesn't show aliases but only the class of the source service. This works for services that use the id=fqcn convention, but that's inaccurate in the general case.
I don't know if we can reorder the passes to dump before resolving, but as is, this PR doesn't make sense to me. |
|
If we dump before resolving, we might end up missing other information in the debug commands by displaying the state before most compiler pass have run |
|
@nicolas-grekas oki i got you, to be fair I've juste restarted it, blindly copy/pasting for now so the PR get visible |
Note
This PR restarts the work achieved by @jlslew in #47427
as per #47427 (comment)
I do think this PR can give some valueable data (like one of my prev PR)
so I am continuing the work already done, to push it forward :)
I may need help/guidance for understanding the tests logic of such descriptor, as they are quite complicated :s