[Form] NumberType: Fix parsing of numbers in exponential notation and negative exponent #57860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A value like 1E-3 results in a float value, even if it not contains the decimal separator. NumberFormatter can parse this correctly, but we need to pass TYPE_DOUBLE. Before it were only used when the string contained the decimal separator, therefore the TYPE_INT was used before (which resulted in the inproper result of 0).
|
Hey! Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch "5.4, 6.4, 7.0, and 7.1 for bug fixes". Cheers! Carsonbot |
jbtronics
requested review from
lyrixx,
dunglas,
welcoMattic,
kbond,
chalasr,
OskarStark and
jderusse
as code owners
|
Replaced by #57861 As this PR is against the wrong branch (7.2 instead of 7.1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when inputting a string like "1E-3" into a NumberType leads incorrectly to a result of "0". The correct result would be "0.001", which is also the result, when inputting "1.0E-3".
This is caused by
NumberToLocalizedStringTransformer, which assumes that the result must be a integer, if the string does not contain the decimal separator. However, this behavior is incorrect, if the string is in exponential notation with negative exponent.The NumberFormatter can correctly parse this format, but it needs to be told that the result should be a double (otherwise its gets incorrectly rounded to 0)
To fix this behavior, I added a check for the negative exponential format, which then results in a double result.