[JsonEncoder] Add object to normalize method #59281
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This rather complicates the normalizer API so allow me to ask: do we really want this conceptually? Do we already know about use cases other than the |
|
After rethinking it, I agree with you. This should be delegated to a precedent step (such as a mapping step). Having the object here will unexpectedly allow the user to change the object data during the normalization step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When normalizing a property, the whole object is sometimes useful.
For example, in API Platform if we want to convert resource ID to an IRI, we'll have to use https://github.com/api-platform/core/blob/main/src/Metadata/IriConverterInterface.php#L46 which needs the whole resource to gather some data and create the IRI.