[Config] Make ifFalse() consistent between value and closure based checks #59995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.3 for features". Cheers! Carsonbot |
src/Symfony/Component/Config/Definition/Builder/ExprBuilder.php
Outdated
Show resolved
Hide resolved
arjenm
force-pushed
the
fix/ifFalse
branch
2 times, most recently
from
97066e7 to
bedf8ca
Compare
src/Symfony/Component/Config/Definition/Builder/ExprBuilder.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Config/Definition/Builder/ExprBuilder.php
Outdated
Show resolved
Hide resolved
|
@nicolas-grekas your suggestions look good, I applied them :) |
nicolas-grekas
force-pushed
the
fix/ifFalse
branch
from
ad4d9c0 to
335bdbe
Compare
|
Thank you @arjenm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the Config/ExpBuilder got a nice new ifFalse in Symfony 7.3.
But I think its implementation is confusing.
The behavior for
ifTrue()was:trueexecute the then parttrueexecute the then partThe behavior for
ifFalse()is prior to this PR is:falseexecute the then parttrueexecute the then partWith this PR it becomes:
falseexecute the then partfalseexecute the then partRationale, I think people (me included) would not expect these to be both be valid or invalid with the same input:
$expr->ifTrue(self::valueIsNotValid(...))->thenInvalid()$expr->ifFalse(self::valueIsNotValid(...))->thenInvalid()They/I expect to have to change it to a test for valid values (rather than invalid ones):
$expr->ifFalse(self::valueIsValid(...))->thenInvalid()