[Messenger] Fix Oracle errors 'ORA-00955: Name is already used by an existing object' with Doctrine transport #60211
Conversation
nicolas-grekas
changed the title
|
Can you please have a look at the test failures? They're related for the component. |
| $serverVersion = $this->driverConnection->executeQuery("SELECT version FROM product_component_version WHERE product LIKE 'Oracle Database%'")->fetchOne(); | ||
| if (version_compare($serverVersion, '12.1.0', '>=')) { | ||
| $idColumn->setAutoincrement(false); // disable the creation of SEQUENCE and TRIGGER | ||
| // The line below is taken into account only if Oracle version is >= 12.1.0 |
There was a problem hiding this comment.
I think this clear by the version compare, right? So do we need this comment?
There was a problem hiding this comment.
Yes, you're right, I can remove it.
Sorry, I'm new to GitHub and PR stuff. And I still have a few tests with errors :(
fabbot.io tells me that I should have done a “rebase” instead of a “merge” when i synchronize upstream/7.2 with my fix branch. And I don't understand why I have to write -\strlen() instead of -strlen()...
There was a problem hiding this comment.
There is a few functions in PHP which benefit from a special compilation into OPCodes (making their execution faster), but those optimization require the call to be fully qualified instead of using the global function fallback. strlen is one of those functions, which is why our CI enforces qualifying calls so that we benefit from the optimizations.
There was a problem hiding this comment.
-strlen() has already been there for a long time thru several versions , so may I fix it?
|
Still have some failing checks, may anyone help ? |
Initialization of MESSENGER objects causes an Oracle error when using
messenger:setup-transports.For more explanation, please see issue #59903