[AssetMapper] Allow adding integrity metadata to importmaps #60378
Conversation
MatTheCat
force-pushed
the
ticket_60362
branch
2 times, most recently
from
37d5d36 to
4648474
Compare
|
If you want to check, started some work was done here #58722 (and was waiting for people to step in and help, so really glad you did here 👍 ) |
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
MatTheCat
force-pushed
the
ticket_60362
branch
3 times, most recently
from
365d76d to
f401b42
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
MatTheCat
force-pushed
the
ticket_60362
branch
3 times, most recently
from
9fd9f8a to
4d298bf
Compare
MatTheCat
force-pushed
the
ticket_60362
branch
2 times, most recently
from
f2d138f to
46efd35
Compare
| @@ -52,6 +52,7 @@ public function __construct( | |||
| private array $dependencies = [], | |||
| private array $fileDependencies = [], | |||
| private array $javaScriptImports = [], | |||
| public ?string $integrity = null, | |||
There was a problem hiding this comment.
If possible i would make it readonly as the digest ere.. so not a ppp
There was a problem hiding this comment.
Made it readonly, but why not a ppp?
There was a problem hiding this comment.
Yep you're right, it's in fact the exact opposite situation that generated problems, when we after we added no porperties on one of the cached class... many people had problems during upgrade.
😶
There was a problem hiding this comment.
Not sure to understand, but if old MappedAssets are serialized in a cache, accessing their new $integrity property would crash; is that what we must be guarding from?
There was a problem hiding this comment.
Yes that was that, proof i'm not clear in my head about this.
But yeah, should be attnetive that really was cause of frustrations for users.
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
MatTheCat
force-pushed
the
ticket_60362
branch
2 times, most recently
from
9f28569 to
33b4561
Compare
MatTheCat
changed the title
Takes over #58722 because I missed it existed..!