[Ldap][Security] Remove deprecated eraseCredentials() from (User|Token)Interface
#60742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
eraseCredentials() from (User|Token)InterfaceeraseCredentials() from (User|Token)Interface
chalasr
force-pushed
the
remove-erasecredentials
branch
2 times, most recently
from
9127d07 to
e1ed824
Compare
Fan2Shrek
approved these changes
Jun 9, 2025
alexandre-daubois
approved these changes
Jun 11, 2025
nicolas-grekas
approved these changes
Jun 15, 2025
| @@ -209,10 +209,6 @@ private function executeAuthenticator(AuthenticatorInterface $authenticator, Req | |||
| // announce the authentication token | |||
| $authenticatedToken = $this->eventDispatcher->dispatch(new AuthenticationTokenCreatedEvent($authenticatedToken, $passport))->getAuthenticatedToken(); | |||
|
|
|||
| if ($this->eraseCredentials) { | |||
There was a problem hiding this comment.
we might need a plan to remove the property now
There was a problem hiding this comment.
You mean deprecating on 7.4?
OskarStark
reviewed
Jun 15, 2025
UPGRADE-8.0.md
Outdated
|
|
||
| ```php | ||
| #[\Deprecated] | ||
| public function eraseCredentials(): void |
There was a problem hiding this comment.
Shouldn't this method be removed here?
nicolas-grekas
force-pushed
the
remove-erasecredentials
branch
from
e1ed824 to
7909077
Compare
nicolas-grekas
force-pushed
the
remove-erasecredentials
branch
from
7909077 to
513a272
Compare
|
Thank you @chalasr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't deprecate the config option + container parameter from SecurityBundle nor the corresponding
AuthenticatorManagerconstructor param, I propose to keep them no-op and deprecate them in 8.1 (mainly becauseAuthenticatorManageralready deprecates a boolean parameter in 7.3 which makes deprecating the parameter complicates the bc layer and upgrade path significantly).