[Serializer] Remove deprecated escape_char functionality from CsvEncoder
#60924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OskarStark
commented
Jun 27, 2025
OskarStark
commented
| Q | A |
|---|---|
| Branch? | 8.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | -- |
| License | MIT |
OskarStark
force-pushed
the
remove-csv-encoder-escape-char
branch
2 times, most recently
from
017afac to
394c99e
Compare
|
Status: Needs work |
stof
reviewed
Jun 27, 2025
stof
reviewed
Jun 27, 2025
OskarStark
force-pushed
the
remove-csv-encoder-escape-char
branch
from
394c99e to
d181c80
Compare
OskarStark
force-pushed
the
remove-csv-encoder-escape-char
branch
4 times, most recently
from
8415da5 to
42f4008
Compare
OskarStark
commented
Jun 27, 2025
OskarStark
commented
Jun 27, 2025
UPGRADE-8.0.md
Outdated
| ->toArray(); | ||
| ``` | ||
|
|
||
| *After* |
There was a problem hiding this comment.
In another case, I had the before/after be a diff. I feel like it might be worth using this style here.
I fear the file might end up overcrowded if we do these before/after all the time 😬
nicolas-grekas
force-pushed
the
remove-csv-encoder-escape-char
branch
from
e777c8f to
3fcfca4
Compare
|
Thank you @OskarStark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.