[SecurityBundle] Remove deprecated OIDC token handler options algorithm and key
#60929
+20
−123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OskarStark
commented
Jun 27, 2025
OskarStark
commented
| Q | A |
|---|---|
| Branch? | 8.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | -- |
| License | MIT |
OskarStark
commented
Jun 27, 2025
...y/Bundle/SecurityBundle/DependencyInjection/Security/AccessToken/OidcTokenHandlerFactory.php
Outdated
Show resolved
Hide resolved
OskarStark
force-pushed
the
remove-oidc-deprecated-options
branch
2 times, most recently
from
3b3362f to
3ae1f9f
Compare
OskarStark
force-pushed
the
remove-oidc-deprecated-options
branch
from
739e44a to
4412c83
Compare
nicolas-grekas
force-pushed
the
remove-oidc-deprecated-options
branch
from
88009ec to
e011b0f
Compare
|
Thank you @OskarStark. |
stof
reviewed
Jun 30, 2025
| ->arrayNode('algorithm') | ||
| ->info('Algorithm used to sign the token.') | ||
| ->setDeprecated('symfony/security-bundle', '7.1', 'The "%node%" option is deprecated and will be removed in 8.0. Use the "algorithms" option instead.') | ||
| ->end() | ||
| ->arrayNode('algorithms') |
There was a problem hiding this comment.
we need fixXmlConfig('algorithm') to convert the single to plural for the XML format for the prototyped node
There was a problem hiding this comment.
OskarStark
added a commit
to OskarStark/symfony
that referenced
this pull request
Jun 30, 2025
Add fixXmlConfig() calls for 'issuers' and 'algorithms' arrays to allow using singular XML tags that get automatically converted to plural form. This improves XML configuration ergonomics. As requested in PR symfony#60929
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.