Skip to content

Fix typos in documentation and code comments #60932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
use Symfony\Component\HttpFoundation\Response;

/**
* Test to convert a request/response back and forth to make sure we do not loose data.
* Test to convert a request/response back and forth to make sure we do not lose data.
*
* @author Tobias Nyholm <tobias.nyholm@gmail.com>
*/
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ CHANGELOG
* added Client::enableProfiler()
* a new parameter has been added to the DIC: `router.request_context.base_url`
You can customize it for your functional tests or for generating URLs with
the right base URL when your are in the CLI context.
the right base URL when you are in the CLI context.
* added support for default templates per render tag

2.1.0
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/HttpFoundation/Tests/RequestTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -1559,7 +1559,7 @@ public static function providePreferredLanguage(): iterable
yield '"fr_FR" is selected as "fr" is a similar dialect (2)' => ['fr_FR', 'ja-JP,fr;q=0.5,en_US;q=0.3', ['en_US', 'fr_FR']];
yield '"fr_FR" is selected as "fr_CA" is a similar dialect and has a greater "q" compared to "en_US" (2)' => ['fr_FR', 'ja-JP,fr_CA;q=0.7,ru-ru;q=0.3', ['en_US', 'fr_FR']];
yield '"fr_FR" is selected as "fr_CA" is a similar dialect and has a greater "q" compared to "en"' => ['fr_FR', 'ja-JP,fr_CA;q=0.7,en;q=0.5', ['en_US', 'fr_FR']];
yield '"fr_FR" is selected as is is an exact match as well as "en_US", but with a greater "q" parameter' => ['fr_FR', 'en-us;q=0.5,fr-fr', ['en_US', 'fr_FR']];
yield '"fr_FR" is selected as it is an exact match as well as "en_US", but with a greater "q" parameter' => ['fr_FR', 'en-us;q=0.5,fr-fr', ['en_US', 'fr_FR']];
yield '"hi_IN" is selected as "hi_Latn_IN" is a similar dialect' => ['hi_IN', 'fr-fr,hi_Latn_IN;q=0.5', ['hi_IN', 'en_US']];
yield '"hi_Latn_IN" is selected as "hi_IN" is a similar dialect' => ['hi_Latn_IN', 'fr-fr,hi_IN;q=0.5', ['hi_Latn_IN', 'en_US']];
yield '"en_US" is selected as "en_Latn_US+variants+extensions" is a similar dialect' => ['en_US', 'en-latn-us-fonapi-u-nu-numerical-x-private,fr;q=0.5', ['fr_FR', 'en_US']];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ private function validateSignature(array $content, string $secret, string $webho
// First add url to signedData.
$signedData = $webhookUrl;

// When no params is set we know its a test and we set the key to test.
// When no params is set we know it's a test and we set the key to test.
if ('[]' === $content['mandrill_events']) {
$secret = 'test-webhook';
}
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Mailer/Bridge/Sendgrid/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ framework:
routing:
sendgrid:
service: mailer.webhook.request_parser.sendgrid
secret: '!SENDGRID_VALIDATION_SECRET!' # Leave blank if you dont want to use the signature validation
secret: '!SENDGRID_VALIDATION_SECRET!' # Leave blank if you don't want to use the signature validation
```

And a consume:
Expand Down
4 changes: 2 additions & 2 deletions src/Symfony/Component/Translation/Bridge/Phrase/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Phrase locale names
-------------------

Translations being imported using the Symfony XLIFF format in Phrase, locales are matched on locale name in Phrase.
Therefor it's necessary the locale names should be as defined in [RFC4646](https://www.ietf.org/rfc/rfc4646.txt) (e.g. pt-BR rather than pt_BR).
Therefore it's necessary the locale names should be as defined in [RFC4646](https://www.ietf.org/rfc/rfc4646.txt) (e.g. pt-BR rather than pt_BR).
Not doing so will result in Phrase creating a new locale for the imported keys.

Locale creation
Expand All @@ -45,7 +45,7 @@ Cache
-----

The read responses from Phrase are cached to speed up the read and delete methods of this provider and also to contribute to the rate limit as little as possible.
Therefor the factory should be initialised with a PSR-6 compatible cache adapter.
Therefore the factory should be initialised with a PSR-6 compatible cache adapter.

Fine tuning your Phrase api calls
---------------------------------
Expand Down
Loading