[FrameworkBundle] fix lint:container command
#60942
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santysisi
force-pushed
the
fix/lint-container-command
branch
from
5018fdd to
e191359
Compare
santysisi
changed the title
lint:container command
|
status: needs work |
carsonbot
changed the title
lint:container commandlint:container command
santysisi
force-pushed
the
fix/lint-container-command
branch
from
e191359 to
0196be5
Compare
|
status: needs review |
santysisi
commented
Jun 29, 2025
Comment on lines
+20
to
+27
| private bool $public = false; | ||
| private array $deprecation = []; | ||
|
|
||
| public function __construct( | ||
| private string $id, | ||
| private bool $public = false, | ||
| bool $public = false, | ||
| ) { | ||
| $this->public = $public; |
There was a problem hiding this comment.
If we want to avoid changing the __constructor, we can use the magic __unserialize method instead:
public function __unserialize(array $data): void
{
$this->id = $data['id'];
$this->public = $data['public'] ?? false;
$this->deprecation = $data['deprecation'] ?? [];
}
santysisi
changed the title
lint:container commandlint:container command
|
I'll try to add some tests as soon as possible. |
|
Thank you @santysisi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves two issues related to the
lint:containercommand:Incorrect use of
isDebug()method: TheisDebug()method was being called on the$container, but this method does not exist there. The correct call should be on the$kernelinstance.Issue during container unserialization: When unserializing the dumped container to retrieve the
ContainerBuilder, problem was with the service aliases. Thepublicproperty was not correctly initialized because the constructor is bypassed during unserialization.