[Routing] Fix subdomain routing with host parameter defaults #60976
+133
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a route has host parameters with defaults (e.g., {subdomain}.example.com
with defaults ['subdomain' => 'en']), it should match requests where the host
doesn't provide those parameters (e.g., example.com should match with subdomain='en').
🤖 Generated with [Claude Code](https://claude.ai/code)
carsonbot
changed the title
|
Thanks for your work. |
|
Thanks for your work, again. Seems OK for me now. So, this works: when setting values for defaults, they are used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a route has host parameters with defaults (e.g.,
{subdomain}.example.comwith defaults['subdomain' => 'en']), it should match requests where the host doesn't provide those parameters (e.g., example.com should match with subdomain='en').