[Security] Removal deprecated RememberMeToken::getSecret() and RememberMeToken's $secret property
#61011
+8
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ktherage
commented
Jul 1, 2025
ktherage
commented
| Q | A |
|---|---|
| Branch? | 8.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | -- |
| License | MIT |
…erMeToken's secret property
ktherage
changed the title
RememberMeToken::getSecret() and RememberMeToken's $secret property
…ions are triggered
OskarStark
reviewed
Jul 1, 2025
src/Symfony/Component/Security/Core/Authentication/Token/RememberMeToken.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Jul 1, 2025
| public function __serialize(): array | ||
| { | ||
| // $this->firewallName should be kept at index 1 for compatibility with payloads generated before Symfony 8 | ||
| return [$this->secret, $this->firewallName, parent::__serialize()]; | ||
| // Newly serialized data removes the secret deprecated since Symfony 7.2 and removed in Symfony 8.0 |
There was a problem hiding this comment.
You mean the comment ? or the method ?
…berMeToken.php Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
ktherage
force-pushed
the
RememberMeToken-bc-layer-removal
branch
from
1f75ede to
002f9c9
Compare
ktherage
force-pushed
the
RememberMeToken-bc-layer-removal
branch
from
002f9c9 to
63e71e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.