[Serializer] add can to the accessor prefixes recognized by the AttributeLoader
#61023
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he AttributeLoader The ObjectNormalizer already recognizes `canX` as an accessor and "generates" a property for that, the AttributeLoader does not, so #[Ignore] attributes on `canX` are ignored, the return value is encoded in the normalized data. We just add the `can` prefix ot the list of accepted accessor prefixes, so the AttributeLoader now also recognized these.
This comment has been minimized.
This comment has been minimized.
carsonbot
changed the title
can to the accessor prefixes recognized by the AttributeLoadercan to the accessor prefixes recognized by the AttributeLoader
OskarStark
changed the title
can to the accessor prefixes recognized by the AttributeLoadercan to the accessor prefixes recognized by the AttributeLoader
welcoMattic
reviewed
Jul 4, 2025
Comment on lines
+32
to
+36
| #[Ignore] | ||
| public function getSomethingElse(): int | ||
| { | ||
| return 42; | ||
| } |
There was a problem hiding this comment.
This additional test case seems not related to your PR topic. Is there a use for it that I've missed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ObjectNormalizer already recognizes
canXas an accessor and "generates" a property for that, the AttributeLoader does not, so #[Ignore] attributes oncanXare ignored, the return value is encoded in the normalized data.We just add the
canprefix ot the list of accepted accessor prefixes, so the AttributeLoader now also recognized these.I adapted a test that seemd to me to fit the best. If you'd prefer a dedicated test for that, I can do that, too.