[DomCrawler] Added missing docblocks and removed redundant type in a return annotation #9025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakzal
commented
Sep 13, 2013
jakzal
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| @@ -85,7 +85,7 @@ public function add($node) | |||
| * @param string $content A string to parse as HTML/XML | |||
| * @param null|string $type The content type of the string | |||
| * | |||
| * @return null|void | |||
| * @return null | |||
| * @param string $siblingDir | ||
| * | ||
| * @return array | ||
| */ | ||
| private function sibling($node, $siblingDir = 'nextSibling') |
There was a problem hiding this comment.
you could even typehint the first argument (it is not a BC break as it is a private method)
There was a problem hiding this comment.
Yeah, I was considering it but was afraid it's gonna be treated as a BC break.
There was a problem hiding this comment.
The great benefit of private methods is that we can do whatever we want, so go for it.
There was a problem hiding this comment.
This one became protected in 2.3 btw.
fabpot
added a commit
that referenced
this pull request
Sep 13, 2013
This PR was merged into the 2.2 branch. Discussion ---------- [DomCrawler] Added missing docblocks and removed redundant type in a return annotation | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- d414213 [DomCrawler] Added missing docblocks and removed unneeded return annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.