-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DomCrawler] Added missing docblocks and removed redundant type in a return annotation #9025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jakzal
commented
Sep 13, 2013
Q | A |
---|---|
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | - |
License | MIT |
Doc PR | - |
@@ -85,7 +85,7 @@ public function add($node) | |||
* @param string $content A string to parse as HTML/XML | |||
* @param null|string $type The content type of the string | |||
* | |||
* @return null|void | |||
* @return null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All @return null
can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
* @param string $siblingDir | ||
* | ||
* @return array | ||
*/ | ||
private function sibling($node, $siblingDir = 'nextSibling') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could even typehint the first argument (it is not a BC break as it is a private method)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was considering it but was afraid it's gonna be treated as a BC break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The great benefit of private methods is that we can do whatever we want, so go for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one became protected in 2.3 btw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, let's not change it then
This PR was merged into the 2.2 branch. Discussion ---------- [DomCrawler] Added missing docblocks and removed redundant type in a return annotation | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- d414213 [DomCrawler] Added missing docblocks and removed unneeded return annotation.